Fix Unknown method: SetInteractive for agama questions mode non-interactive (#709)
#712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ractive` (#709) We want to access Interactive, a writable property. zbus-xmlgen generates a proxy for setting a writable property but forgets to mark it as a property, generating a method call instead
|
The NetworkManager proxies fixed here are not used in our client code. I checked with |
jreidinger
approved these changes
Aug 22, 2023
mvidner
added a commit
to mvidner/zbus
that referenced
this pull request
Aug 23, 2023
The `#[dbus_proxy(property)]` attribute needs to be present also at the `set_foo` function, otherwise the proxy will call a `SetFoo` method instead of `Set`ting the `Foo` property. Example: agama-project/agama#712
Merged
mvidner
added a commit
that referenced
this pull request
Dec 5, 2023
Same issue as in #712: zbus-xmlgen generates a proxy for setting a writable property but forgets to mark it as a property, generating a method call instead (I fixed zbus-xmlgen in August but they haven't released a crate since June)
mvidner
added a commit
that referenced
this pull request
Jan 19, 2024
Same issue as in #712: zbus-xmlgen generates a proxy for setting a writable property but forgets to mark it as a property, generating a method call instead (I fixed zbus-xmlgen in August but they haven't released a crate since June)
mvidner
added a commit
that referenced
this pull request
Feb 1, 2024
Same issue as in #712: zbus-xmlgen generates a proxy for setting a writable property but forgets to mark it as a property, generating a method call instead (I fixed zbus-xmlgen in August but they haven't released a crate since June)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #709:
When I use our CLI,
agama questions mode non-interactiveIt calls a
org.opensuse.Agama.Questions1.SetInteractivemethod on/org/opensuse/Agama/Questions1but the actual API is anInteractiveproperty.Solution
Fix the generated proxies to include a
dbus_proxy(property)attribute.(other
proxies.rsfiles either do not have writable properties or already have this fix applied)An upstream fix for https://github.com/dbus2/zbus will follow.
Testing
Tested manually:
Screenshots
See above.