Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark translatable texts #700

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Mark translatable texts #700

merged 2 commits into from
Aug 11, 2023

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Aug 11, 2023

Problem

  • The texts in the web UI are not marked for translation

Notes

  • This is just the first round, it does not cover all files, let's do it in smaller steps
  • Adjusted building the POT file using xgettext, originally copied from the Cockpit code but make it better:
    • Use the JavaScript format (it betters parses the code and does not add the c-format marks)
    • Define only the keywords used by Agama (e.g. we do not use contexts)

- First round, not finished yet
@lslezak lslezak marked this pull request as ready for review August 11, 2023 11:47
@coveralls
Copy link

Coverage Status

coverage: 72.14% (-0.003%) from 72.143% when pulling 4a58c38 on web_translations into 459221b on master.

Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit ab2e5c9 into master Aug 11, 2023
10 checks passed
@lslezak lslezak deleted the web_translations branch August 11, 2023 12:18
@imobachgs imobachgs mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants