Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack dev server: Fixed locale handling (null check) #685

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Webpack dev server: Fixed locale handling (null check) #685

merged 2 commits into from
Aug 3, 2023

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Aug 3, 2023 •
edited
Loading

Properly handle locales with just a language code without country (e.g. "cs").

In that case country is null and calling toUpperCase() fails... 😮

@lslezak
Webpack dev server: Fixed locale handling
f74eae0 
Properly handle locale with just a language code without country
(e.g. "cs")
imobachgs
imobachgs approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but you might want to try the optional chaining operator.

@coveralls
Copy link

coveralls commented Aug 3, 2023 •
edited
Loading

Coverage Status

coverage: 72.079%. remained the same when pulling 2be011d on webpack_locale_fix into fa00c19 on master.

imobachgs
imobachgs approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still LGTM. Thanks!

@lslezak lslezak merged commit 57d328b into master Aug 3, 2023
14 checks passed
@lslezak lslezak deleted the webpack_locale_fix branch August 3, 2023 09:46
@imobachgs imobachgs mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lslezak @coveralls @imobachgs