Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use html-webpack-plugin for minifying HTML in production #680

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Jul 31, 2023

Problem

  • The HTML file is not minified in production
  • This is related to PR Load Agama translations #677 which added a quite big comment into the index.html file

Solution

  • As the index.html is not that big it is not a major problem but IMHO it is a good idea to do it anyway
  • Additionally it supports bundling the favicon so we can remove our hack, the favicon tag is injected by the plugin automatically

Testing

  • Tested manually, in the production mode the comments and the extra spacing is removed, in development mode the code is unchanged
  • In both cases it injects the favicon tag properly

@coveralls
Copy link

Coverage Status

coverage: 72.051%. remained the same when pulling b00fb3c on minify_html into e8f9b93 on master.

@lslezak lslezak marked this pull request as draft August 1, 2023 09:11
@lslezak
Copy link
Contributor Author

lslezak commented Aug 1, 2023

Note: Let's merge this one after releasing the Dolomite image.

@lslezak lslezak marked this pull request as ready for review August 4, 2023 12:13
@lslezak lslezak merged commit 5c2c562 into master Aug 4, 2023
14 checks passed
@lslezak lslezak deleted the minify_html branch August 4, 2023 12:47
@imobachgs imobachgs mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants