Update installer status #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use EventMachine to do polling on the D-Bus socket.
* It breaks the circular dependency of DBus::Installer and Installer. * The Installer class knows nothing about D-Bus.
* This call is still commented, but now it will work if it is uncommented.
jreidinger
reviewed
Dec 27, 2021
| To build and run this software you need a few tools. To install them on openSUSE | ||
| Tumbleweed just type: | ||
|
|
||
| $ sudo zypper in gcc gcc-c++ make openssl-devel ruby-devel npm |
|
lets merge it now as it can do partitioning and software installation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventMachine::PeriodicTimer, but probably there is a better way.Installer#on_status_changein order to inject a callback which is called when the status change. There was some kind of a circular dependency betweenDBus::InstallerandInstaller(I only was able to call the#StatusChangedsignal through the `DBus::Installer).DBus::InstallerClientdoes not exist anymore because of the previous change.TODO: the status update is not handled in the web UI yet.*
Some videos
Partitioning the disk (you need to uncomment the inst_prepdisk client call:
Delivering properties and status changes to the browser: