Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Drop support for disabled fieldsets #354

Merged
merged 2 commits into from
Dec 5, 2022
Merged

[web] Drop support for disabled fieldsets #354

merged 2 commits into from
Dec 5, 2022

Conversation

dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Dec 5, 2022 •
edited
Loading

Problem

Firefox does not seem to follow the fieldset's disabled attr specification, preventing the event propagation of elements contained within the first descendant of the legend and breaking the intended behavior of the Encrypt devices group in the ProposalSettingsForm.

Solution

To disable each fieldset child manually until finding a better solution. Fortunately, it's only a PasswordAndConfirmationInput component right now.

Testing

  • Unit tests updated
  • Tested manually too

@dgdavid
[web] Remove Fieldset support for "disabled" attr
dad1b62 
Because Firefox does not seem to follow the specification[1], preventing event
propagation of elements contained within the first descendant of the legend and
breaking the intended behavior.

  > The disabled attribute, when specified, causes all the form control
  > descendants of the fieldset element, excluding those that are descendants
  > of the fieldset element's first legend element child, if any, to be
  > disabled.

[1] https://html.spec.whatwg.org/#attr-fieldset-disabled
@dgdavid
[web] Allow disabling PasswordAndConfirmation input
a5c3937
@dgdavid dgdavid changed the title Fieldset hotfix [web] Drop support for disabled fieldsets Dec 5, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.396% when pulling a5c3937 on fieldset-hotfix into f28b24a on master.

@dgdavid dgdavid merged commit 4971719 into master Dec 5, 2022
@dgdavid dgdavid deleted the fieldset-hotfix branch December 5, 2022 14:17
@imobachgs imobachgs mentioned this pull request Dec 5, 2022
Merged
@dgdavid dgdavid mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgdavid @coveralls @imobachgs