Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Still missing Swedish 23th September 2024 #1629

Closed
bittin opened this issue Sep 23, 2024 · 7 comments
Closed

Still missing Swedish 23th September 2024 #1629

bittin opened this issue Sep 23, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@bittin
Copy link

bittin commented Sep 23, 2024

testing now with todays 23th Septembers iso: https://download.opensuse.org/repositories/systemsmanagement:/Agama:/Devel/images/iso/agama-installer.x86_64-openSUSE.iso , more Swedish now at least, but its not fully complete yet but maybe there is some strings thats not on Weblate yet ?
@imobachgs
Copy link
Contributor

Please, put some example so we can have a look.

@imobachgs
Copy link
Contributor

Oh, and the link you posted is generic; it does not tell us which build you are using.

@bittin
Copy link
Author

bittin commented Sep 23, 2024

@imobachgs https://imgur.com/a/cIZXZDH here is a couple of examples that still have text in english, sorry still sick so was a bit lazy and that is the build from today so Agama 10 25.3

@imobachgs
Copy link
Contributor

The untranslated strings are coming from the backend and they are translated in weblate.

@imobachgs imobachgs added the bug Something isn't working label Sep 23, 2024
@bittin bittin mentioned this issue Sep 23, 2024
Closed
@imobachgs imobachgs mentioned this issue Sep 27, 2024
Merged
imobachgs added a commit that referenced this issue Sep 27, 2024
@imobachgs
fix: handle language change in users and storage (#1642)
c94f7d9 
## Problem

Some parts of the UI are not properly translated (see #1629).

## Solution

Properly refresh the issues in the users and storage services.

## Testing

- Tested manually
@imobachgs imobachgs mentioned this issue Sep 27, 2024
Merged
imobachgs added a commit that referenced this issue Sep 27, 2024
@imobachgs
fix: translate storage component when UI language changes (#1644)
e7a8f50 
## Problem

Some parts of the UI are not properly translated when the language of
the UI changes (see #1629).

## Solution

This is a fix for storage components which consist on not calling `_` at
module level.

## Testing

- Tested manually
@imobachgs
Copy link
Contributor

#1642, #1643 and #1644 should fix those problems. There is only one glitch while displaying the language change progress, but that's a different topic we might need to address with some serious refactoring.

@imobachgs imobachgs mentioned this issue Sep 27, 2024
Merged
imobachgs added a commit that referenced this issue Sep 27, 2024
@imobachgs
fix(web): fix localization of overview headers (#1645)
ded8adb 
## Problem

Related to #1629.

Overview headers are not translated.

## Solution

Do not call `_()` at module level (see #1643).

## Testing

- Tested manually
@imobachgs
Copy link
Contributor

Oh, I almost forgot: the pattern descriptions in the software section are not translated because the repository does not contain any translation to Swedish.

@bittin
Copy link
Author

bittin commented Oct 7, 2024

This is still not fixed, just tried the Leap 16 Pre Alpha image

alright where to translate the pattern descriptions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imobachgs @bittin