-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cursor component: fixes for WebXR mode #5528
base: master
Are you sure you want to change the base?
Conversation
While I'm not entirely sure about the history of the As for the event listeners, the change looks good, but |
I am doing some tests with the Vision Pro. The If we use a camera rig like below, it is necessary to add the
I see your point with the |
I see, I still think this is something that the Put differently, there is no meaningful reason to use a different entity than the rig. And since A-Frame knows the reference space and the relevant transform of the reference space (parent transform of the active camera), there's no reason to require the user to specify/configure it manually.
Updating the PR would be nice, it makes sense to have |
I updated the handling of the WebXR event listeners such that they are correctly registered/unregistered. |
Description:
This PR fixes a couple of small issues when using the
cursor
component withrayOrigin: xrselect
.Changes proposed:
cursor
component is attached to an entity other thana-scene
, an error occurs.cursor
attribute is removed.