Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #5083

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #5083

wants to merge 1 commit into from

Conversation

wenqingl
Copy link

Description:
This README is pretty good overall, but I have some grammatical suggestions
Changes proposed:

  • singular and plural
  • preposition


:mag: **Visual Inspector**: A-Frame provides a built-in visual 3D inspector
with a workflow similar to a browser's developer tools and interface similar to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface as in software interface is singular

Unity. Open up any A-Frame scene and hit `<ctrl> + <alt> + i`.

:runner: **Features**: Hit the ground running with A-Frame's built-in
components such as geometries, materials, lights, animations, models,
raycasters, shadows, positional audio, tracked controllers. Get even further
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a list is not exhaustive. Do you think the use of and can be confusing?

@@ -88,15 +88,15 @@ interactive WebVR experiences.

:globe_with_meridians: **Cross-Platform**: Build VR applications for Vive,
Rift, Daydream, GearVR, and Cardboard. Don't have a headset or controllers? No
problem! A-Frame still works on standard desktop and smartphones.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when talking about software. we usually say this software is made for desktop and mobile. Singular is usually used.

@dmarcos
Copy link
Member

dmarcos commented Jul 27, 2022

Thanks! I'm not a great writer. Just made a few comments. Some changes like interfaces read a bit different than I'm used to when talking about technical literature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants