Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added preRender callback #8

Merged
merged 2 commits into from
Nov 23, 2017
Merged

Added preRender callback #8

merged 2 commits into from
Nov 23, 2017

Conversation

SathishGovindaraju
Copy link
Contributor

@SathishGovindaraju SathishGovindaraju commented Nov 20, 2017 •
edited
Loading

  • Callback function which gets called before the component gets rendered

coderas
coderas approved these changes Nov 21, 2017
View reviewed changes
Copy link
Collaborator

@coderas coderas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

joy.

Non-breaking change 👍

afenton90
afenton90 requested changes Nov 23, 2017
View reviewed changes
Copy link
Owner

@afenton90 afenton90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line comment then this is ready to go 👍

README.md Outdated
@@ -67,6 +67,14 @@ For example:
// Other callbacks
}));
```
### `preRender`

Callback function called before rendering `App`. This callback should return a valid component.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to make it clear here that this component can be resolved in a Promise

afenton90
afenton90 approved these changes Nov 23, 2017
View reviewed changes
Copy link
Owner

@afenton90 afenton90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💯
Could I request that an example is added in a future PR.

@afenton90 afenton90 merged commit 2a301eb into afenton90:master Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderas coderas coderas approved these changes

@afenton90 afenton90 afenton90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SathishGovindaraju @afenton90 @coderas