fix: set default background back to none

.ruby-version

@@ -0,0 +1 @@
+2.1.0

CHANGELOG.md

@@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [0.2.6] - 2019-03-23
+### Added
+- Readme troubleshooting for librsvg2-bin package missing
+### Fixed
+- ICO convert uses background config
+
 ## [0.2.5] - 2019-01-16
 ### Changed
 - Strike GraphicsMagick at Readme because it's compatible a this moment

Gemfile.lock

@@ -1,18 +1,18 @@
 PATH
   remote: .
   specs:
-    jekyll-favicon (0.2.5)
+    jekyll-favicon (0.2.6)
       jekyll (~> 3.0)
       mini_magick (~> 4.5)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.2)
+    addressable (2.6.0)
       public_suffix (>= 2.0.2, < 4.0)
     ast (2.4.0)
     colorator (1.1.0)
-    concurrent-ruby (1.1.4)
+    concurrent-ruby (1.1.5)
     em-websocket (0.5.1)
       eventmachine (>= 0.12.9)
       http_parser.rb (~> 0.6.0)
@@ -40,12 +40,12 @@ GEM
     jekyll-watch (2.0.0)
       listen (~> 3.0)
     kramdown (1.17.0)
-    liquid (4.0.1)
+    liquid (4.0.3)
     listen (3.0.8)
       rb-fsevent (~> 0.9, >= 0.9.4)
       rb-inotify (~> 0.9, >= 0.9.7)
     mercenary (0.3.6)
-    mini_magick (4.9.2)
+    mini_magick (4.9.3)
     mini_portile2 (2.3.0)
     minitest (5.11.3)
     minitest-hooks (1.5.0)
@@ -73,7 +73,7 @@ GEM
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
     ruby-progressbar (1.10.0)
-    safe_yaml (1.0.4)
+    safe_yaml (1.0.5)
     sass (3.7.3)
       sass-listen (~> 4.0.0)
     sass-listen (4.0.0)

README.md

@@ -24,12 +24,18 @@ Features: Cipher DPC HDRI Modules
 Delegates (built-in): bzlib freetype jng jpeg ltdl lzma png tiff xml zlib
 ```
 
+If you have a [problem converting SVG files](https://github.com/afaundez/jekyll-favicon/issues/9#issuecomment-473862194), you may need to install the package `librsvg2-bin`. For example, in Ubuntu/Debian systems:
+
+```sh
+sudo apt install librsvg2-bin
+```
+
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'jekyll-favicon', '~> 0.2.5', group: :jekyll_plugins
+gem 'jekyll-favicon', '~> 0.2.6', group: :jekyll_plugins
 ```
 
 ## Usage

lib/jekyll/favicon/config/defaults.yml

@@ -1,9 +1,9 @@
 favicon:
   source: favicon.svg
   path: /assets/images
-  background: white
+  background: none
   apple-touch-icon:
-    background: white
+    background: none
     sizes:
       - 57x57
       - 76x76

lib/jekyll/favicon/icon.rb

@@ -57,7 +57,6 @@ def ico_options
         options = {}
         sizes = Favicon.config['ico']['sizes']
         options[:background] = background_for sizes.first
-        options[:alpha] = 'off'
         options[:resize] = sizes.first
         ico_sizes = sizes.collect { |size| size.split('x').first }.join ','
         options[:define] = "icon:auto-resize=#{ico_sizes}"

lib/jekyll/favicon/version.rb

@@ -1,5 +1,5 @@
 module Jekyll
   module Favicon
-    VERSION = '0.2.5'.freeze
+    VERSION = '0.2.6'.freeze
   end
 end

test/jekyll/favicon/generator_test.rb

@@ -53,6 +53,21 @@
       end
     end
 
+    it 'should honor SVG colors' do
+      img = MiniMagick::Image.open File.join @options['destination'], 'assets',
+                                             'images',
+                                             'favicon-16x16.png'
+      pixels = img.get_pixels
+      assert_equal [0, 0, 0], pixels[0][0]
+      assert_equal [220, 20, 60], pixels[8][8]
+      img = MiniMagick::Image.open File.join @options['destination'], 'assets',
+                                             'images',
+                                             'favicon-57x57.png'
+      pixels = img.get_pixels
+      assert_equal [0, 0, 0], pixels[0][0]
+      assert_equal [220, 20, 60], pixels[26][26]
+    end
+
     it 'should create a webmanifest' do
       assert File.exist? File.join @destination,
                                    @defaults['chrome']['manifest']['target']
@@ -64,6 +79,33 @@
     end
   end
 
+  describe 'when site uses default SVG favicon' do
+    before :all do
+      @options['source'] = fixture 'sites', 'minimal'
+      @options['favicon'] = { 'background' => 'red' }
+      @config = Jekyll.configuration @options
+      @site = Jekyll::Site.new @config
+      @site.process
+      @destination = @options['destination']
+      @defaults = Jekyll::Favicon::DEFAULTS
+    end
+
+    it 'should honor SVG colors' do
+      img = MiniMagick::Image.open File.join @options['destination'], 'assets',
+                                             'images',
+                                             'favicon-16x16.png'
+      pixels = img.get_pixels
+      assert_equal [255, 0, 0], pixels[0][0]
+      assert_equal [220, 20, 60], pixels[8][8]
+      img = MiniMagick::Image.open File.join @options['destination'], 'assets',
+                                             'images',
+                                             'favicon-57x57.png'
+      pixels = img.get_pixels
+      assert_equal [255, 0, 0], pixels[0][0]
+      assert_equal [220, 20, 60], pixels[26][26]
+    end
+  end
+
   describe 'when site uses default PNG favicon' do
     before :all do
       @options['source'] = fixture 'sites', 'minimal-png-source'