fix: validator spec functions return their generic type #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been having an issue where the validator spec functions (
str()
etc.) don't return the correct type when passed a generic.An example:
The return value of
cleanEnv
here isReadonly<{ LOG_LEVEL: string } & CleanedEnvAccessors>
.I would expect it to be
Readonly<{ LOG_LEVEL: LogLevel } & CleanedEnvAccessors>
.If you add in a generic to
cleanEnv
, it highlights the problem further:The line
LOG_LEVEL: str<LogLevel>()
gives a TypeScript error:So
str<LogLevel>()
is returning typeValidatorSpec<string>
when I would expect it to returnValidatorSpec<LogLevel>
.This PR fixes the issue by just passing the generic type into the underlying
makeValidator
function so that the returned validator spec has the correct type.