Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: workaround ci failure by pinning nbconvert<7.14 #652

Merged
merged 6 commits into from
Jan 10, 2024
Merged

docs: workaround ci failure by pinning nbconvert<7.14 #652

merged 6 commits into from
Jan 10, 2024

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Jan 10, 2024 •
edited
Loading

Recently a failure in our CI popped up with messages like these:

/home/runner/work/pymovements/pymovements/docs/source/tutorials/detecting-events.ipynb:163: ERROR: Content block expected for the "raw" directive; none found.

@github-actions github-actions bot added documentation Improvements or additions to documentation labels Jan 10, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b10da5d) 100.00% compared to head (a90db42) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #652   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           54        54           
  Lines         2356      2356           
  Branches       588       588           
=========================================
  Hits          2356      2356

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkrako
Copy link
Contributor Author

dkrako commented Jan 10, 2024

This is related to jupyter/nbconvert#2092

temporarily fixed by keeping nbconvert<7.14

@dkrako dkrako changed the title docs: remove all whitespace cells docs: workaround nbconvert error introduced in nbconvert 7.14 Jan 10, 2024
@dkrako dkrako changed the title docs: workaround nbconvert error introduced in nbconvert 7.14 docs: workaround nbconvert 7.14 error Jan 10, 2024
@dkrako dkrako changed the title docs: workaround nbconvert 7.14 error docs: workaround ci failure with nbconvert 7.14 Jan 10, 2024
@dkrako dkrako changed the title docs: workaround ci failure with nbconvert 7.14 docs: workaround ci docs failure by pinning nbconvert<7.14 Jan 10, 2024
@dkrako dkrako marked this pull request as ready for review January 10, 2024 13:11
@dkrako dkrako changed the title docs: workaround ci docs failure by pinning nbconvert<7.14 docs: workaround ci failure by pinning nbconvert<7.14 Jan 10, 2024
@SiQube SiQube enabled auto-merge (squash) January 10, 2024 13:22
@SiQube SiQube merged commit 9f641c6 into main Jan 10, 2024
19 checks passed
@SiQube SiQube deleted the docs/resolve-sphinx-build-error branch January 10, 2024 15:18
@dkrako dkrako mentioned this pull request Jan 26, 2024
Closed
@dkrako dkrako mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiQube SiQube SiQube approved these changes

@prassepaul prassepaul Awaiting requested review from prassepaul prassepaul is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkrako @SiQube