-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from setuptools to hatchling #1384
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1384 +/- ##
==========================================
- Coverage 74.71% 74.69% -0.02%
==========================================
Files 194 194
Lines 49826 49730 -96
Branches 10539 10527 -12
==========================================
- Hits 37226 37145 -81
+ Misses 10272 10262 -10
+ Partials 2328 2323 -5
|
Ok, I think I got it!!! Excludes are now determined by the root Unlike my previous PRs, once #1371 is merged I want to do a "squash and merge" here, so I'm not curating my individual commits. |
Rebased on latest changes. All tests were green. |
I made another review pass since I hadn't yet checked the wheel. The |
[deleted, wrong PR] |
Still open question: Is there any reason for docs/ to be included in the sdist? It's not in the wheel, and it takes up significant space. |
Good question; I'm not aware of one at the moment, so we can probably remove it. |
Great, let's do it in the next PR though. (One thing at a time.) |
ef111c2
to
888c52c
Compare
Thanks for the approval! Interesting... if I update the branch with a rebase (via the GH interface), then it discards your approving review. But with a merge update, it retains your approval. (Since I ultimately want to squash-and-merge, the Git history will remain linear.) |
Base: #1371
Change the build-backend from setuptools to hatchling.
Question: Is there any reason for
docs/
to be included in the sdist? It's not in the wheel.For some reason I'm having trouble including the fileaesara/d3viz/html/template.html
. I'm not sure yet why it's being excluded.Thank you for opening a PR!
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.
If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.