Close all methods #174
Merged
Close all methods #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjpt777
reviewed
May 28, 2019
| return; | ||
| } | ||
|
|
||
| final List<Exception> exceptions = new ArrayList<>(); |
There was a problem hiding this comment.
It would be better if this was not allocated unless needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common situation is that you want to cleanup multiple of closeable objects. The existing close helper methods aren't very useful as they either suppress the exception or fail to guarantee that everything was closed. Here's a pair of utility methods from Artio that take a list or var-args array of closeables, guarantee they're all closed and don't suppress an exception if there is one. Pull requesting as I've had requests from other people for using this kind of method in non-artio projects and it agrona makes sense as a location.