Handle race condition between File.length() and FileChannel.size() #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed in the wild:
This seems to be caused by
File.length()
returning a value greater than zero, passing this test:but then causing a zero-length buffer to be mapped here:
This PR adds a wait for
FileChannel.size()
to return at least 4, the minimum required to read the version number. I've also added a test to ensure that a more meaningful error message would be thrown in the event of a timeout.