Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

Possibility to pass additional browser container host entries via desiredCapabilities #236

Closed
vgrigoruk opened this issue Oct 5, 2017 · 2 comments
Milestone

Comments

@vgrigoruk
Copy link
Contributor

Ability to pass additional host entries (for browser containers) via capabilities (that override entries defined in browsers.json)?
The use case:

  • testing canary releases to production (application is accessible via production domain, but specific hosts need to be added to /etc/hosts file)
  • these hosts IP addresses are changed between deployments. IP addresses need to be fetched from 3rd-party API (in our case AWS).
  • updating browsers.json for each test run will be a pain in the ass in this case.

Required changes:

  • add support additional capability (e.g. containerHosts="host:ip,host2:ip2,...")
  • ignore the capability if browsers are not running under docker containers
  • merge host entries from containerHosts capability with hosts defined in browsers.json (capability values should override values from browsers.json if there are duplicated entries for the same "host" key)
@vania-pooh vania-pooh added this to the 1.3.8 milestone Oct 5, 2017
@vania-pooh
Copy link
Member

vania-pooh commented Oct 5, 2017

How would you like to pass several entries in one string capability? E.g.:

hostEntries: "example.com:192.168.0.1,test.com:192.168.0.2"

@vgrigoruk
Copy link
Contributor Author

comma- or semicolon-separated entries is ok.

aandryashin added a commit that referenced this issue Oct 6, 2017
Added ability to pass container hosts entries as capability (fixes #236)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants