Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Adding example documentation for using apollo-server-express v3 transformers #133

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Adding example documentation for using apollo-server-express v3 transformers #133

merged 1 commit into from
Dec 3, 2021

Conversation

BigBallard
Copy link
Contributor

Attempted to add the transformers to the this lib but for obvious reasons of using asev3 in your project, there are v2 dependencies in this lib cant be resolved in your project. So I just added documentation for implementing the transformers yourself borrowing this libs logic. Hope it helps.

…ive transformers since this lib cant provide them as of now due to dependency issues.
@wtrocki
Copy link
Contributor

wtrocki commented Dec 3, 2021

I do not think that anyone uses Apollo 2 anymore. I think we can kill completely support for Apollo 2 and assume that everything should work on with 3.

@wtrocki
Copy link
Contributor

wtrocki commented Dec 3, 2021

As well. I'm pretty much still have projects/users using this lib with Apollo 3 by building their schema using graphql-tools.
I would rather prefer graphql-tools rather than using some semi open source features of Apollo platform. This way you could use library with graphql-express or apollo-server without difference

@BigBallard
Copy link
Contributor Author

Ya I would agree with that. Besides, if anyone does use Apollo 2 this version is still available, we would just up the major version. Should we merge these docs for the time being and work on migrating to exclusive Apollo 3, or what would be that path forward, I would like to help 👍

@wtrocki
Copy link
Contributor

wtrocki commented Dec 3, 2021

Thank you so much! It will be hard for me to run the code in the docs but as form of encouragement I will merge that back and see if we can pull all of that into current example application instead later phase.

@wtrocki wtrocki merged commit 272415f into aerogear:master Dec 3, 2021
@BigBallard BigBallard deleted the apollo-sever-3-example-docs branch December 3, 2021 16:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants