-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Time Series Segmentation Benchmark + Human Activity Segmentation Challenge data loaders #1755
Conversation
…gmentation data set loaders + tests.
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Some minor comments.
Thanks @patrickzib for the review. I pushed the requested changes. |
LGTM, @TonyBagnall ? @MatthewMiddlehurst ? |
excellent! |
I'll take a closer look later, but all looks fine to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could I put them on tsc.com to load from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit difficult to tell without using them, but looks fine for me. Fits with the current loaders and your tests pass so fine to work out any potential issues later.
Sure @TonyBagnall, please go ahead! :-) |
What does this implement/fix? Explain your changes.
I added data loaders for the time series segmentation benchmark (TSSB) [1] and human activity segmentation challenge data sets [2].
[1] Arik Ermshaus, Patrick Schäfer, Ulfer Leser: ClaSP: parameter-free
time series segmentation. Data Mining and Knowledge Discovery, 2023,
DOI:10.1007/s10618-023-00923-x.
[2] Arik Ermshaus, Patrick Schäfer, Anthony Bagnall, Thomas Guyet,
Georgiana Ifrim, Vincent Lemaire, Ulf Leser, Colin Leverger,
Simon Malinowski: Human Activity Segmentation Challenge @ ECML/PKDD’23.
AALTD@ECML, 2023, DOI:10.1007/978-3-031-49896-1_1.