Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Time Series Segmentation Benchmark + Human Activity Segmentation Challenge data loaders #1755

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

ermshaua
Copy link
Contributor

@ermshaua ermshaua commented Jul 3, 2024

What does this implement/fix? Explain your changes.

I added data loaders for the time series segmentation benchmark (TSSB) [1] and human activity segmentation challenge data sets [2].

[1] Arik Ermshaus, Patrick Schäfer, Ulfer Leser: ClaSP: parameter-free
time series segmentation. Data Mining and Knowledge Discovery, 2023,
DOI:10.1007/s10618-023-00923-x.

[2] Arik Ermshaus, Patrick Schäfer, Anthony Bagnall, Thomas Guyet,
Georgiana Ifrim, Vincent Lemaire, Ulf Leser, Colin Leverger,
Simon Malinowski: Human Activity Segmentation Challenge @ ECML/PKDD’23.
AALTD@ECML, 2023, DOI:10.1007/978-3-031-49896-1_1.

@aeon-actions-bot aeon-actions-bot bot added datasets Datasets and data loaders enhancement New feature, improvement request or other non-bug code enhancement labels Jul 3, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#0B1D38}{\textsf{datasets}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)

Copy link
Contributor

@patrickzib patrickzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Some minor comments.

aeon/datasets/_tss_data_loaders.py Outdated Show resolved Hide resolved
aeon/datasets/_tss_data_loaders.py Show resolved Hide resolved
aeon/datasets/tests/test_tss_data_loader.py Show resolved Hide resolved
aeon/datasets/tests/test_tss_data_loader.py Show resolved Hide resolved
@ermshaua
Copy link
Contributor Author

ermshaua commented Jul 4, 2024

Thanks @patrickzib for the review. I pushed the requested changes.

@patrickzib
Copy link
Contributor

LGTM, @TonyBagnall ? @MatthewMiddlehurst ?

@TonyBagnall
Copy link
Contributor

excellent!

@TonyBagnall
Copy link
Contributor

I'll take a closer look later, but all looks fine to me

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could I put them on tsc.com to load from?

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit difficult to tell without using them, but looks fine for me. Fits with the current loaders and your tests pass so fine to work out any potential issues later.

@TonyBagnall TonyBagnall merged commit 8f81a73 into aeon-toolkit:main Jul 4, 2024
14 checks passed
@ermshaua
Copy link
Contributor Author

ermshaua commented Jul 5, 2024

LGTM, could I put them on tsc.com to load from?

Sure @TonyBagnall, please go ahead! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Datasets and data loaders enhancement New feature, improvement request or other non-bug code enhancement segmentation Segmentation package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants