Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] write_to_tsfile not writing header #1329

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Conversation

vNtzYy
Copy link
Contributor

@vNtzYy vNtzYy commented Mar 21, 2024

  • Parameter now passed correctly.

What does this implement/fix? Explain your changes.

Saving a collection of time series in np.ndarrays or list format with the write_to_tsfile method did not create the header correctly. A parameter was missing and is now passed.

Does your contribution introduce a new dependency? If yes, which one?

No.

Any other comments?

My first ever PR, let me know if there is anything to improve!
Unsure if this is a BUG or MNT.

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

Sorry, something went wrong.

* Parameter now passed correctly.
@aeon-actions-bot aeon-actions-bot bot added bug Something isn't working datasets Datasets and data loaders labels Mar 21, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ bug ].
I have added the following labels to this PR based on the changes made: [ datasets ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@MatthewMiddlehurst
Copy link
Member

@all-contributors add @vNtzYy for bug

Copy link
Contributor

@MatthewMiddlehurst

I've put up a pull request to add @vNtzYy! 🎉

@baraline baraline merged commit a5a2c8f into aeon-toolkit:main Mar 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datasets Datasets and data loaders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants