Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ph #459

Merged
merged 3 commits into from
Dec 26, 2024
Merged

Fix ph #459

merged 3 commits into from
Dec 26, 2024

Conversation

foucblg
Copy link
Contributor

@foucblg foucblg commented Dec 21, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.94%. Comparing base (a40c8d9) to head (29d5bf0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   53.94%   53.94%           
=======================================
  Files         169      169           
  Lines        3756     3756           
=======================================
  Hits         2026     2026           
  Misses       1730     1730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marc-Andrieu
Copy link
Contributor

Marc-Andrieu commented Dec 21, 2024

Fix #457
Fix #458

Note: the scope of this PR is limited to the admin page

Copy link
Contributor

@Marc-Andrieu Marc-Andrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested: both fixes work

@Rotheem Rotheem merged commit 1b70721 into main Dec 26, 2024
2 of 3 checks passed
@Rotheem Rotheem deleted the Fix-PH branch December 26, 2024 14:51
maximeroucher pushed a commit that referenced this pull request Jan 11, 2025
Co-authored-by: Foucauld Bellanger <63885990+Foukki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants