-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove POST request if pdf not changed #431
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
=======================================
Coverage 53.82% 53.82%
=======================================
Files 168 168
Lines 3727 3727
=======================================
Hits 2006 2006
Misses 1721 1721 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not setting the editPdfNotifier to false, which mean that once you have edited a pdf all this other will trigger the POST request regardless of the fact that it has been updated or not.
I think you can add the set false once you have successfully updated the pdf
EditPdfNotifier() : super(false); | ||
|
||
void editPdf(bool bool) { | ||
state = bool; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you name this variable differently
Ofc thank you |
No description provided.