Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove POST request if pdf not changed #431

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Remove POST request if pdf not changed #431

merged 3 commits into from
Sep 19, 2024

Conversation

foucblg
Copy link
Contributor

@foucblg foucblg commented Sep 18, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.82%. Comparing base (ab209c2) to head (95b4e88).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   53.82%   53.82%           
=======================================
  Files         168      168           
  Lines        3727     3727           
=======================================
  Hits         2006     2006           
  Misses       1721     1721           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maximeroucher maximeroucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not setting the editPdfNotifier to false, which mean that once you have edited a pdf all this other will trigger the POST request regardless of the fact that it has been updated or not.
I think you can add the set false once you have successfully updated the pdf

EditPdfNotifier() : super(false);

void editPdf(bool bool) {
state = bool;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you name this variable differently

@foucblg
Copy link
Contributor Author

foucblg commented Sep 18, 2024

You are not setting the editPdfNotifier to false, which mean that once you have edited a pdf all this other will trigger the POST request regardless of the fact that it has been updated or not. I think you can add the set false once you have successfully updated the pdf

Ofc thank you

@maximeroucher maximeroucher merged commit 7ef0e3c into main Sep 19, 2024
3 checks passed
@maximeroucher maximeroucher deleted the Fix-ph-edit branch September 19, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants