-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove windows folder #303
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
=======================================
Coverage 56.03% 56.03%
=======================================
Files 161 161
Lines 3514 3514
=======================================
Hits 1969 1969
Misses 1545 1545 ☔ View full report in Codecov by Sentry. |
Maybe consider gitignoring the folder to make sure it does not get included on another commit |
I don't see why fluttter would regenerate the windows folder but if it does then we can gitignore it. |
This folder is generated when someone build for windows, even for debug, which can happen sometimes |
Yes but why someone would build this project with windows ? |
It happens to the best of us 🙄 |
Does it still give the option without the windows folder ? I can't try because I only have Flutter on Linux. |
Building for windows without having the folder will generate it |
Ok I added it to the .gitignore |
We should remove the windows folder as we are not supporting this platform.