Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove windows folder #303

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Remove windows folder #303

merged 3 commits into from
Feb 25, 2024

Conversation

julien4215
Copy link
Contributor

We should remove the windows folder as we are not supporting this platform.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.03%. Comparing base (81c265f) to head (056d8d2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   56.03%   56.03%           
=======================================
  Files         161      161           
  Lines        3514     3514           
=======================================
  Hits         1969     1969           
  Misses       1545     1545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximeroucher
Copy link
Member

Maybe consider gitignoring the folder to make sure it does not get included on another commit

@julien4215
Copy link
Contributor Author

Maybe consider gitignoring the folder to make sure it does not get included on another commit

I don't see why fluttter would regenerate the windows folder but if it does then we can gitignore it.

@maximeroucher
Copy link
Member

This folder is generated when someone build for windows, even for debug, which can happen sometimes

@julien4215
Copy link
Contributor Author

Yes but why someone would build this project with windows ?

@guillaumetavernier
Copy link
Contributor

Yes but why someone would build this project with windows ?

It happens to the best of us 🙄
(It's often the default option while compiling on VS Code)

@julien4215
Copy link
Contributor Author

Does it still give the option without the windows folder ? I can't try because I only have Flutter on Linux.
Also does it allow you to build on windows even if there is no windows folder in the project ?

@maximeroucher
Copy link
Member

Building for windows without having the folder will generate it

@julien4215
Copy link
Contributor Author

Ok I added it to the .gitignore

@guillaumetavernier guillaumetavernier merged commit 3791c95 into main Feb 25, 2024
5 checks passed
@guillaumetavernier guillaumetavernier deleted the remove-windows branch February 25, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants