Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommendation #242

Merged
merged 19 commits into from
Mar 4, 2024
Merged

Recommendation #242

merged 19 commits into from
Mar 4, 2024

Conversation

julien4215
Copy link
Contributor

@julien4215 julien4215 commented Dec 26, 2023 •
edited
Loading

Add recommendation module

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 43.75000% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 55.79%. Comparing base (0d8b573) to head (3e6dfab).

Files Patch % Lines
lib/recommendation/class/recommendation.dart 38.46% 16 Missing ⚠️
...dation/repositories/recommendation_repository.dart 0.00% 13 Missing ⚠️
...dation/providers/recommendation_list_provider.dart 72.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
- Coverage   56.01%   55.79%   -0.22%     
==========================================
  Files         161      164       +3     
  Lines        3515     3579      +64     
==========================================
+ Hits         1969     1997      +28     
- Misses       1546     1582      +36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maximeroucher
maximeroucher reviewed Dec 27, 2023
View reviewed changes
Copy link
Member

@maximeroucher maximeroucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome !!
Can you add some screenshot to give us an idea of the UI 😉

@maximeroucher maximeroucher added enhancement New feature or request ready for review This PR is ready to be reviewed labels Jan 4, 2024
maximeroucher
maximeroucher reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@maximeroucher maximeroucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work !!
Your commits are really well done !
Just waiting Hyperion to approve this

lib/recommendation/ui/pages/add_edit_page.dart Outdated Show resolved Hide resolved
@julien4215 julien4215 force-pushed the recommendation branch 2 times, most recently from 305aed1 to 356bd28 Compare February 12, 2024 14:02
@julien4215 julien4215 force-pushed the recommendation branch 2 times, most recently from 1f553f6 to c87ae10 Compare February 22, 2024 17:21
@julien4215 julien4215 force-pushed the recommendation branch 2 times, most recently from 143b370 to 36abbcf Compare February 23, 2024 19:00
@guillaumetavernier guillaumetavernier merged commit 511e307 into main Mar 4, 2024
9 checks passed
@julien4215 julien4215 deleted the recommendation branch March 4, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximeroucher maximeroucher maximeroucher approved these changes

@guillaumetavernier guillaumetavernier guillaumetavernier approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ready for review This PR is ready to be reviewed waiting backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julien4215 @codecov-commenter @maximeroucher @guillaumetavernier