Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise ValueError in phone validator #552

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

armanddidierjean
Copy link
Member

to let FastAPI return Pydantic ValidationError instead of crashing

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the documentation, if necessary

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.57%. Comparing base (e0c8337) to head (93e7df1).

Files with missing lines Patch % Lines
app/utils/validators.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   81.58%   81.57%   -0.02%     
==========================================
  Files         125      125              
  Lines        9823     9822       -1     
==========================================
- Hits         8014     8012       -2     
- Misses       1809     1810       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant