Module sport results #394
Draft
Module sport results #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanddidierjean
requested changes
Apr 7, 2024
| @@ -0,0 +1,183 @@ | |||
| from collections.abc import Sequence | |||
| from sqlite3 import IntegrityError | |||
There was a problem hiding this comment.
Suggested change
| from sqlite3 import IntegrityError | |
| from sqlalchemy.exc import IntegrityError |
| result.sport_id, | ||
| db, | ||
| ): | ||
| raise HTTPException(status_code=401, detail="Not a captain") |
There was a problem hiding this comment.
Suggested change
| raise HTTPException(status_code=401, detail="Not a captain") | |
| raise HTTPException(status_code=403, detail="Not a captain") |
Comment on lines
+106
to
+208
| result_complete = schemas_sport_results.ResultComplete( | ||
| id=str(uuid.uuid4()), | ||
| **result.model_dump(), | ||
| ) |
There was a problem hiding this comment.
Do we really need to instantiate this intermediate variable?
|
|
||
|
|
||
| class Sport(Base): | ||
| __tablename__ = "sports" |
There was a problem hiding this comment.
Suggested change
| __tablename__ = "sports" | |
| __tablename__ = "sport_sport" |
|
|
||
|
|
||
| class Result(Base): | ||
| __tablename__ = "result" |
There was a problem hiding this comment.
Suggested change
| __tablename__ = "result" | |
| __tablename__ = "sport_result" |
BLEMENT33
force-pushed
the
module-sport-results
branch
from
bcc220a
to
5e36580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made a module to show sport results of all the sport teams to Centraliens