password requirements

[BLEMENT33]

Description

update our password validators to unsure new users' password are strong enough.
We need to coordinate this with Titan.

Fix: #330

[codecov]

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (57670d0) to head (20740ea).
Report is 1 commits behind head on main.

Files	Patch %	Lines
app/utils/validators.py	77.77%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   82.87%   82.90%   +0.02%     
==========================================
  Files          98       98              
  Lines        6185     6199      +14     
==========================================
+ Hits         5126     5139      +13     
- Misses       1059     1060       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[armanddidierjean]

Should we add some unit tests?

[armanddidierjean]

As remarked by @Rotheem, you should use strip() before the validation

[Rotheem]

And more importantly, use RegEx please

[Rotheem]

The use of RegEx make the code cleaner.

Suggested change

	nb_number, nb_special, nb_maj, nb_min = 0, 0, 0, 0
	for i in password:
	if i.isnumeric():
	nb_number += 1
	elif not i.isalpha():
	nb_special += 1
	elif i.isupper():
	nb_maj += 1
	elif i.islower():
	nb_min += 1
	if len(password) < 6 or nb_number < 1 or nb_special < 1 or nb_min < 1 or nb_maj < 1:
	if len(password) < 6 or not (re.search(r'[a-z]',password) and re.search(r'[A-Z]',password) and re.search(r'[0-9]',password) and re.search(r'[!@#$%^&*(),.?":{}|<>]-_',password)):

[armanddidierjean]

We should use the same algorithm as Calypsso

[gitguardian]

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
13092605	Triggered	Generic Password	87ad009	tests/test_users.py	View secret
13092606	Triggered	Generic Password	87ad009	tests/test_users.py	View secret
13092607	Triggered	Generic Password	87ad009	tests/test_users.py	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}