Use integer cents in AMAP / Tombola #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BLEMENT33
requested review from
armanddidierjean,
Petitoto and
guillaumetavernier
| [ticket.pack_ticket.price / ticket.pack_ticket.pack_size for ticket in tickets] | ||
| ) | ||
| )) |
There was a problem hiding this comment.
The goal of this PR is to avoid imprecision errors. Maybe there is a way to avoid dividing values before converting to int
|
Nice one ! You will need to look into migration files to convert float euro database values to new int cent values |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
=======================================
Coverage 78.26% 78.26%
=======================================
Files 76 76
Lines 5351 5351
=======================================
Hits 4188 4188
Misses 1163 1163 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I change all the amounts in cents (integer) to avoid rounding issues.