-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restore xml parsing to avoid postgis request #89
Conversation
@xcaeag woa so fast! Did you really review it before? I had not time to set up my local test environment! |
not familiar with reviews. I trust, I integrate, I test then! |
@xcaeag Wasn't expecting a merge this quick ! If anything turns out to be wrong I will quickly do a fix. |
well, it rocks!
all loaded in.. 2s |
@jmkerloch can you remember me the related issue upstream on QGIS project please? |
I created an issue about layer notes that should be corrected in master : qgis/QGIS#58818 But if we wan't to be as fast as xml parsing there are other optimization needed in Qgis core. |
Can you develop a bit please? |
It has been backported to 3.34. |
I need to do some tests but this wasn't as fast as xml parsing. I remember for instance query to database in case of postgis layer. |
Even with the use of flags
QgsProject.FlagDontResolveLayers | QgsProject.FlagDontLoadLayouts | QgsProject.FlagTrustLayerMetadata | QgsProject.FlagDontStoreOriginalStyles
we still see some request to postgis if there are postgis layer in the project.If the number of layer is big this really increase project load time.
To avoid that this PR restore the use of xml parsing for project menu configuration definition.
QgsDomManager
is created to store all the loaded xml projects (was previously in plugin main):project_read.py
to use xml parsing.