Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add location option to create menus in QGIS browser from project #129

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

jmkerloch
Copy link
Collaborator

@jmkerloch jmkerloch commented Nov 29, 2024

Related to #107 #128

First implementation of QGIS browser use to display project.

Missing:

For this a refactoring of layer load to use a list of layer configuration for Add all option instead of using actions available in menu. This couldn't be used in the QGIS browser.

@Guts Guts changed the title Feat/project in qgis browser Feature: add location option to create menus in QGIS browser from project Nov 29, 2024
@Guts
Copy link
Collaborator

Guts commented Dec 16, 2024

Thanks for your work on this.

So the PR does not ship any UI widget to configure the menu location (menu, browser, new layer) right?

@jmkerloch
Copy link
Collaborator Author

Thanks for your work on this.

So the PR does not ship any UI widget to configure the menu location (menu, browser, new layer) right?

For now there is no configuration for the browser. I'm waiting for the new project configuration UI.
Keeping PR as Draft until that.

@Guts Guts added this to the 2.3.0 milestone Dec 17, 2024
@jmkerloch jmkerloch force-pushed the feat/project_in_qgis_browser branch from 964582e to 836eedb Compare December 20, 2024 08:14
@jmkerloch
Copy link
Collaborator Author

@Guts I just added the option to add project in QGIS browser.

We also support merge of project, but ⚠️ currently we have no way of keeping the order of the layer so the layer will be mixed between project.

@jmkerloch jmkerloch marked this pull request as ready for review December 20, 2024 08:17
@jmkerloch jmkerloch requested a review from Guts December 20, 2024 08:18
@Guts
Copy link
Collaborator

Guts commented Dec 20, 2024

We also support merge of project, but ⚠️ currently we have no way of keeping the order of the layer so the layer will be mixed between project.

Can you add a documentation section or page with the new option, including this limitation please?

Copy link
Collaborator

@Guts Guts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 !

Thanks for taking in account all my remarks and concerns 🙏.

@jmkerloch jmkerloch merged commit 3118929 into master Dec 20, 2024
8 checks passed
@jmkerloch jmkerloch deleted the feat/project_in_qgis_browser branch December 20, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants