Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: help menu was leading to a 404 #118

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Fix: help menu was leading to a 404 #118

merged 3 commits into from
Nov 13, 2024

Conversation

Guts
Copy link
Collaborator

@Guts Guts commented Nov 13, 2024 •
edited
Loading

  • use a simpler method to open help menu
  • use documentation as homepage

to be merged after #116

@Guts Guts requested a review from jmkerloch November 13, 2024 14:40
@Guts Guts self-assigned this Nov 13, 2024
@Guts Guts force-pushed the fix/help-menu branch 2 times, most recently from 37aa573 to 74b13b0 Compare November 13, 2024 15:26
jmkerloch
jmkerloch approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@jmkerloch jmkerloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Guts Guts merged commit 0ef10f8 into master Nov 13, 2024
5 checks passed
@Guts Guts deleted the fix/help-menu branch November 13, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmkerloch jmkerloch jmkerloch approved these changes

Assignees

@Guts Guts

Labels
bug UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Guts @jmkerloch