-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SkipFilters to SDK #86
Changes from all commits
3ffd38e
1e07bb2
ebf9b75
1191ec6
c1db6ce
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,11 +13,11 @@ import { | |
RequestContext, | ||
ResponseContext, | ||
Placement, | ||
} from './generated'; | ||
RequiredError, | ||
UserdbApi | ||
} from '@adzerk/api-decision-js'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm happy that you removed the generated code from the repo! Much cleaner and less confusing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thank you |
||
import { DecisionRequest, DecisionResponse } from './models'; | ||
import { removeUndefinedAndBlocklisted } from './utils'; | ||
import { UserdbApi } from './generated/apis/UserdbApi'; | ||
import { RequiredError } from './generated/runtime'; | ||
import { LoggerFunc } from '.'; | ||
|
||
(global as any).FormData = (global as any).FormData || FormData; | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like these rely on NPM_REGISTRY and NPM_SECRET, don't they? Am I right in assuming that this step won't have those values, as they've been moved into the step below instead of living at the top level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally yes, but what I've done is wrap the shell variables in single quotes as the actual values will be substituted in by npm when
npm publish
is run.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That line creates a file called
.npmrc
with the contents:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm publish
then substitutes those values in from env variables when run