Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log failed auth attempts #3295

Closed
wants to merge 1 commit into from

Conversation

faush01
Copy link
Contributor

@faush01 faush01 commented Aug 17, 2024

Log failed auth attempts for local auth mode.
This should allow for better monitoring of brute force user/password attacks.

@nichwall
Copy link
Contributor

nichwall commented Aug 17, 2024

Partially fixes #2579 based on follow up comments

Partially fixes #2533 (not sure if that request is for logging both local and OAuth attempts)

@advplyr
Copy link
Owner

advplyr commented Aug 17, 2024

This is better implemented in Auth than in the local auth lib. I added it here 1b914d5 along with logs for successful local auth logins.

@advplyr advplyr closed this Aug 17, 2024
@faush01
Copy link
Contributor Author

faush01 commented Aug 17, 2024

Thanks, makes sense.
I was not sure how best to get the req into the call, I did see the option passReqToCallback but it was weird as sometimes a function was passed in to options. I am not really a fan of JS with its loose var types, and having logic use detected var types makes my head hurt.

@faush01 faush01 deleted the feature/log_failed_auth branch August 26, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants