Adds genres to gloabl search #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixed missing encodeURIComponent on the query (which caused ampersand in query not to be handled correctly), in both GlobalSearch.vue and pages/.../_library/search.vue |
|
Thanks! I think that icon makes sense for genres |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2937
This adds genres to the global search dropdown (for both Books and Podcast libraries).
Since the number of results in the dropdown is limited, I also added "ORDER By numItems DESC" to the tags and genres search queries, so we return the most useful ones first.
I chose "category" from the material symbols to denote genres. Please feel free to replace this with anything else.