Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssrfFilter url #3043

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Fix ssrfFilter url #3043

merged 1 commit into from
Jun 5, 2024

Conversation

dbrain
Copy link
Contributor

@dbrain dbrain commented Jun 5, 2024

The recent commit to support disabling the ssrfFilter has broken url loading for non podcasts due to a copy paste error from the podcasts file. This switches the feedUrl back to the original url and makes image loading, and my kid waiting on a new audiobook, happy.

The original issue likely had a few ways to trigger it but in my scenario it was updating an audiobooks metadata and replacing the image, the error in the logs was:

[Server] Unhandled rejection: ReferenceError: feedUrl is not defined, promise: Promise { <rejected> ReferenceError: feedUrl is not defined at /snapshot/audiobookshelf-git/server/utils/fileUtils.js at new Promise (<anonymous>) at Object.downloadFile (/snapshot/audiobookshelf-git/server/utils/fileUtils.js) at /snapshot/audiobookshelf-git/server/utils/fileUtils.js at CoverManager.downloadCoverFromUrl (/snapshot/audiobookshelf-git/server/managers/CoverManager.js) at async ApiRouter.uploadCover (/snapshot/audiobookshelf-git/server/controllers/LibraryItemController.js) at async ApiRouter.updateMedia (/snapshot/audiobookshelf-git/server/controllers/LibraryItemController.js) }

After switching to my branch this error no longer occurs and the image is updated correctly.

@advplyr
Copy link
Owner

advplyr commented Jun 5, 2024

Thanks!

@advplyr advplyr merged commit 065aae9 into advplyr:master Jun 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants