Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dir="auto" attribute where RTL display is needed #2797

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

mikiher
Copy link
Contributor

@mikiher mikiher commented Mar 28, 2024

This adds dir="auto" attribute to some text elements, in which it makes sense to modify the display when the text is in a RTL language (e.g. Arabic, Hebrew, Urdu, etc.)

The change has no effect on LTR text. The main visible difference in RTL text is that it is naturally aligned to the right (and there are also some subtler differences in the rendering of mixed text containing both RTL and LTR characters).

Some examples after the change:

In the Latest Episodes page:
Screenshot 2024-03-29 000604

In the Recently Added row on the Homepage:
Screenshot 2024-03-29 000937

You can see in both examples how Hebrew text is right-aligned (as expected), while English text remains as-is.

Note: this is not an attempt at full RTL support for the Hebrew locale (which will likely require more work).

@mikiher mikiher marked this pull request as ready for review March 28, 2024 22:18
@advplyr
Copy link
Owner

advplyr commented Mar 29, 2024

Great start, thanks!

@advplyr advplyr merged commit 1396a43 into advplyr:master Mar 29, 2024
2 checks passed
@mikiher mikiher deleted the rtl-fixes branch July 12, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants