Fix book limit for the Continue Series shelf (with skip earlier books toggle active) #2789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Continue Series shelf (with skip earlier books toggle active) returns some weird results if you have more than 10 series which has a read book, but not all of them have a book that qualifies for the constrains of being of a higher sequence number than the ones already finished.
This is because the sql query returns the 10 series with most recent progress that fit for the untoggled library setting.
In order to solve the issues caused by this, I added the same sql query that calculates the
maxSequence
number to the original where-query, so that it will only return series that we know has books in them that are of a higher sequence than the ones already read.The post-query code is still there, since the query still returns books that are below the
maxSequence
number.Unfortunately the
maxSequenceQuery
is run twice against the db, but I did not figure out a better way of running the query in the current code base.I am open to suggestions on improvements, though!