Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fr.json #2485

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Update fr.json #2485

merged 2 commits into from
Jan 5, 2024

Conversation

Machou
Copy link
Contributor

@Machou Machou commented Jan 3, 2024

No description provided.

@advplyr
Copy link
Owner

advplyr commented Jan 4, 2024

We can't have comments in the JSON file.
The context for those:

LabelDatetime: This is the column header for a table that is a column of dates with times
image

LabelDiscFromFilename and LabelDiscFromMetadata: These are column headers when editing tracks to show where the disc number was pulled from, the filename or from the audio file meta tags.
image

LabelFinished: This is used in the progress box
image

@Machou
Copy link
Contributor Author

Machou commented Jan 5, 2024

I have other question, about the word "Item", you use this word for many string.

Item is only for book audio ? or other ? because i don't like use "Article" in french.

@advplyr
Copy link
Owner

advplyr commented Jan 5, 2024

Item is short for "library item". At the moment a library item can only be a book or a podcast but in the future if we add more media types it could be a music track or something.
I'm not sure if that helps translate.

@Machou
Copy link
Contributor Author

Machou commented Jan 5, 2024

Item is short for "library item". At the moment a library item can only be a book or a podcast but in the future if we add more media types it could be a music track or something. I'm not sure if that helps translate.

I'll think about it and ask people who are better in French to help me.

You can merge if it's Ok for you, I've double-checked and found nothing to correct =)

@advplyr
Copy link
Owner

advplyr commented Jan 5, 2024

Thanks!

@advplyr advplyr merged commit fbe228a into advplyr:master Jan 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants