Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Confirmation dialog before navigating away from bulk edit with unsaved changes #3369

Closed
nichwall opened this issue Sep 2, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@nichwall
Copy link
Contributor

nichwall commented Sep 2, 2024

Type of Enhancement

Web Frontend

Describe the Feature/Enhancement

A confirmation dialog about unsaved changes on the bulk edit screen would be helpful. Several users have mentioned problems with the bulk edit page in the past, but they have been due to not having pressed the "Save" button in the lower right of the screen.

This may be useful with other edit modals as well.

Why would this be helpful?

This just tripped me up while searching for edge cases on 2.13.2 related to the model transition, so I just kept trying to debug exactly which fields were not being applied correctly. Then I realized I wasn't pressing save.

Future Implementation (Screenshot)

image

Audiobookshelf Server Version

v2.13.2

Current Implementation (Screenshot)

No user confirmation

@nichwall nichwall added the enhancement New feature or request label Sep 2, 2024
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

Fixed in v2.13.3.

@github-actions github-actions bot closed this as completed Sep 2, 2024
@github-actions github-actions bot removed the awaiting release Issue is resolved and will be in the next release label Sep 2, 2024
@advplyr
Copy link
Owner

advplyr commented Sep 2, 2024

This could be further improved by showing our Confirm modal when navigating internally instead of the browser default confirm prompt.
I believe the browser default confirm prompt would still have to be shown for navigation not made in the website. e.g. the browser back button

nichwall pushed a commit to nichwall/audiobookshelf that referenced this issue Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants