Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: metadata.json not updated #2837

Closed
richterma opened this issue Apr 9, 2024 · 3 comments
Closed

[Bug]: metadata.json not updated #2837

richterma opened this issue Apr 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@richterma
Copy link

Describe the issue

When using the Settings / Item Metadata Utils to make changes to Tags/Genres or edit Author / Narrator information via the respective dialogs, the metadata for all affected books seems to be updated in the db.
However, at the same time, the metadata.json is not updated.

I have just noticed this after quite a big cleanup.
Apart from any potential solution for this ticket: Is there any way to force a re-write of all or all affected files?

Steps to reproduce the issue

  1. (Maybe relevant) Enable option to write metadata.json next to the library files.
  2. Tag a book with Narrator "Mister Taipo".
  3. Go to the Narrator tab. Edit "Mister Taipo", change it to "Mister Typo".
  4. Check book info within Audiobookshelf and the metadata.json in the filesystem.

Audiobookshelf version

v2.8.1

How are you running audiobookshelf?

Docker

@richterma richterma added the bug Something isn't working label Apr 9, 2024
@nichwall
Copy link
Contributor

nichwall commented Apr 9, 2024

Are you looking at the metadata JSON file located next to the media files, like /audiobooks/Author/Book/metadata.json, or are you looking in /metadata/items/[uuid]/metadata.json?

Do files exist in both locations, and if so is one of them being updated correctly, just not the one you expect?

@richterma
Copy link
Author

I'm looking at the files in /audiobooks/*, which I enabled in the settings.
There are no files in /metadata/items (in fact, the directory doesn't even exist).

Looking at the delete function in AuthorController.js, I guess this actually is "as designed" in the current code. It seems like there just is no code to update the files.

@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Apr 12, 2024
@advplyr
Copy link
Owner

advplyr commented Apr 22, 2024

Fixed in v2.9.0

@advplyr advplyr closed this as completed Apr 22, 2024
@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants