Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Player Web controls should be propper buttons #2599

Closed
rkingett opened this issue Feb 9, 2024 · 1 comment
Closed

[Bug]: Player Web controls should be propper buttons #2599

rkingett opened this issue Feb 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@rkingett
Copy link

rkingett commented Feb 9, 2024

Describe the issue

I am using the NVDA screen reader on Windows, running an instance of ABS on PikaPods, but the version is Version 2.7.2.

NVDA isn't registering the player controls as a <button> tag. They appear as plain text elements. Perhaps these should be changed to proper buttons so that mobile web browsers could also take advantage of the changes?

NVDA is an open source screen reader and can be found at https://github.com/nvaccess/nvda

The below explains more about clickable elements and why they might not work in all cases, especially mobile browsers.

https://developer.mozilla.org/en-US/docs/Learn/Accessibility/HTML

Steps to reproduce the issue

Audiobookshelf version

2.7.2

How are you running audiobookshelf?

Other

@rkingett rkingett added the bug Something isn't working label Feb 9, 2024
@rkingett rkingett changed the title [Bug]: Web controls should be propper buttons [Bug]: Player Web controls should be propper buttons Feb 9, 2024
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Feb 15, 2024
@advplyr
Copy link
Owner

advplyr commented Feb 20, 2024

Fixed in v2.8.0

@advplyr advplyr closed this as completed Feb 20, 2024
@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants