Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Series sequence is not pulled when parsing OPF metadata file #2505

Closed
advplyr opened this issue Jan 7, 2024 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@advplyr
Copy link
Owner

advplyr commented Jan 7, 2024

Describe the issue

When parsing the following stripped down OPF file the series sequence is not pulled because it is not directly under the series name.
This is from the package document in an ebook file.

<?xml version='1.0' encoding='utf-8'?>
<package xmlns="http://www.idpf.org/2007/opf" unique-identifier="BookId" version="2.0">
  <metadata xmlns:calibre="http://calibre.kovidgoyal.net/2009/metadata" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:dcterms="http://purl.org/dc/terms/" xmlns:opf="http://www.idpf.org/2007/opf" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
    <meta name="calibre:series" content="La Faucheuse"/>
    <meta name="calibre:title_sort" content="FAUCHEUSE 02 Thunderhead"/>
    <meta name="calibre:series_index" content="2.0"/>
  </metadata>
</package>

An adjustment in a recent PR to support multiple series broke this use-case. To support this if there is only 1 series listed then it should use the series_index no matter where it is.

Steps to reproduce the issue

  1. Create OPF file with XML above and place inside a new folder with an ebook
  2. Scan in the new book
  3. Observe a series with no sequence

Audiobookshelf version

v2.7.1

How are you running audiobookshelf?

Built from source

@advplyr advplyr added the bug Something isn't working label Jan 7, 2024
advplyr added a commit that referenced this issue Jan 9, 2024
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Jan 9, 2024
@advplyr
Copy link
Owner Author

advplyr commented Feb 18, 2024

@advplyr advplyr closed this as completed Feb 18, 2024
@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant