Use proper syntax for gitlab job dependencies #1750
Conversation
|
I see some sort of error I haven't entirely understood yet: https://main.gitlab.in.here.com/olp/edge/ota/connect/client/aktualizr/-/pipelines/1021912 |
|
Doh! I really wish gitlab's yaml was designed from scratch by someboby who knows what they are doing. Alas, we have to deal with haphazard collection of features randomly bolted on each other. The fix is waiting for repo sync. |
Codecov Report
@@ Coverage Diff @@
## master #1750 +/- ##
==========================================
- Coverage 84.98% 84.86% -0.12%
==========================================
Files 178 178
Lines 12019 12019
==========================================
- Hits 10214 10200 -14
- Misses 1805 1819 +14
Continue to review full report at Codecov.
|
ci/gitlab/.gitlab-ci.yml
Outdated
| @@ -293,6 +293,7 @@ Ptest qemux86_64: | |||
| GIT_CHECKOUT: false | |||
| dependencies: | |||
| - OE Checkout | |||
| needs: ["OE Checkout"] | |||
There was a problem hiding this comment.
Why does this one need both keywords specified?
There was a problem hiding this comment.
Pre-lunch commits are rarely good idea :-/
zabbal
force-pushed
the
feat/gitlab
branch
6 times, most recently
from
a8e7578 to
99cd775
Compare
The 'dependencies' actually means the list of artifacts, while the dependencies are expressed with 'needs' keyword which by default implies artifact list as well. While at it, also reduce code duplication by using templates. N. B: we have to be careful with optional jobs because this might lead to yaml error in case of 'needs' referring to non-existent job. Signed-off-by: Max <max.suraev@here.com>
zabbal
force-pushed
the
feat/gitlab
branch
2 times, most recently
from
ff43aad to
36a8894
Compare
Replace ugly sed workaround with proper docker build-time args. Signed-off-by: Max <max.suraev@here.com>
|
I've split changes which could affect release process into separate commit to make it easier to rollback. Release docs: https://docs.ota.here.com/ota-client/latest/release-process.html The failing gitlab pipeline is due to flacky tests in coverage job. I can mark it as optional to work around it or we can merge regardless and proceed with release testing. |
|
The test flakiness is getting really annoying, but it's not new. It's possible that this PR has somehow exacerbated the problems, but I don't really understand how. For now, let's go ahead and merge and see how it goes. We have a ticket already for looking into these tests (https://saeljira.it.here.com/browse/OTA-5194) which can be prioritized if necessary. |
The 'dependencies' actually means the list of artifacts, while the dependencies
are expressed with 'needs' keyword which by default implies artifact list as
well.