This repository has been archived by the owner on May 21, 2024. It is now read-only.
Revert "Don't copy CA certificates to client certificate data" #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c6c3543, which seems to break things when curl is compiled with GnuTLS backend. Signed-off-by: Eugene Smirnov <evgenii.smirnov@here.com>
lbonn
reviewed
Jan 17, 2020
| @@ -297,6 +297,7 @@ bool Crypto::parseP12(BIO *p12_bio, const std::string &p12_password, std::string | |||
| for (int i = 0; i < sk_X509_num(ca_certs.get()); i++) { // NOLINT | |||
| ca_cert = sk_X509_value(ca_certs.get(), i); // NOLINT | |||
| PEM_write_bio_X509(ca_sink.get(), ca_cert); | |||
| PEM_write_bio_X509(cert_sink.get(), ca_cert); | |||
There was a problem hiding this comment.
Could we add a comment here to note that it should not be necessary, works with OpenSSL but not gnutls?
There was a problem hiding this comment.
This is just a quick revert, I'd like to find the root cause before adding any comments. I'll definitely follow up with other PR.
Codecov Report
@@ Coverage Diff @@
## master #1527 +/- ##
==========================================
+ Coverage 81.91% 81.91% +<.01%
==========================================
Files 186 186
Lines 11361 11362 +1
==========================================
+ Hits 9306 9307 +1
Misses 2055 2055
Continue to review full report at Codecov.
|
pattivacek
approved these changes
Jan 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c6c3543,
which seems to break things when curl is compiled with GnuTLS backend.