Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Changelog: update with recent PRs. #1517

Merged
merged 8 commits into from
Jan 20, 2020
Merged

Changelog: update with recent PRs. #1517

merged 8 commits into from
Jan 20, 2020

Conversation

pattivacek
Copy link
Collaborator

@pattivacek pattivacek commented Jan 15, 2020

No description provided.

CHANGELOG.md Show resolved Hide resolved

- Increased Targets metadata file size limit: [PR](https://github.com/advancedtelematic/aktualizr/pull/1476)
- Do not provision if the Primary times out while connecting to Secondaries: [PR](https://github.com/advancedtelematic/aktualizr/pull/1491)
- Check and fetch root metadata according to the Uptane standard: [PR](https://github.com/advancedtelematic/aktualizr/pull/1501)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these more fixes (1501, 1510)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I debated that. I argue that nothing was broken before in either case. I think both items are definite improvements, but to me, "fix" implies that there was a bug.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fair enough.

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #1517 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
- Coverage   81.91%   81.84%   -0.08%     
==========================================
  Files         186      186              
  Lines       11361    11361              
==========================================
- Hits         9306     9298       -8     
- Misses       2055     2063       +8
Impacted Files Coverage Δ
src/libaktualizr/package_manager/ostreemanager.cc 77.52% <0%> (-2.63%) ⬇️
src/libaktualizr/storage/sql_utils.h 84.72% <0%> (-1.39%) ⬇️
src/libaktualizr/storage/sqlstorage.cc 77.05% <0%> (-0.22%) ⬇️
src/libaktualizr/storage/sqlstorage_base.cc 77.7% <0%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f7c6e...c471345. Read the comment docs.

amma and others added 8 commits January 17, 2020 14:55
Signed-off-by: amma <awuraaamma.okyere-boateng@here.com>
Signed-off-by: amma <awuraaamma.okyere-boateng@here.com>
A few spaces were missing, a package has been upgraded, and a few
packages are no longer used.

Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Signed-off-by: amma <awuraaamma.okyere-boateng@here.com>
Signed-off-by: amma <awuraaamma.okyere-boateng@here.com>
Signed-off-by: amma <awuraaamma.okyere-boateng@here.com>
Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
@pattivacek
Copy link
Collaborator Author

Rebased and ready for review.

@pattivacek
Copy link
Collaborator Author

This is ready for review and I will create the next release as soon as this is merged.

@pattivacek pattivacek merged commit 5ead19c into master Jan 20, 2020
@pattivacek pattivacek deleted the docs/prep-2020.1 branch January 20, 2020 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants