Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]: Trying to fix Windows CI #190

Merged
merged 14 commits into from
Oct 15, 2020
Merged

[WIP]: Trying to fix Windows CI #190

merged 14 commits into from
Oct 15, 2020

Conversation

dfm
Copy link
Contributor

@dfm dfm commented Oct 13, 2020 •
edited by adrn
Loading

Describe your changes

@dfm dfm marked this pull request as draft October 13, 2020 15:59
@adrn
Copy link
Owner

adrn commented Oct 13, 2020

Thanks for looking at this! These changes are probably good either way, but still seeing the same issue - weird

@adrn adrn marked this pull request as ready for review October 13, 2020 16:23
@adrn
Copy link
Owner

adrn commented Oct 13, 2020

Hm, well I'm stumped. I tried pinning to a version of tox that previously worked, but now it's failing!

@dfm
Copy link
Contributor Author

dfm commented Oct 13, 2020

That's strange! I'm also stumped but I'll keep thinking about it and let you know if I come up with anything.

@adrn
Copy link
Owner

adrn commented Oct 13, 2020

For future reference, here's a test run that worked:
https://github.com/adrn/gala/runs/1133584563?check_suite_focus=true

@adrn adrn mentioned this pull request Oct 13, 2020
Merged
@adrn
Copy link
Owner

adrn commented Oct 14, 2020

And see Pey Lian's response here: astropy/astropy#10846 (comment)

@adrn
Copy link
Owner

adrn commented Oct 14, 2020

Apparently this issue is seen on travis w/ astropy windows builds that use conda. Also seen in photutils. From Pey Lian in Slack:

I dunno... We already pinned miniconda in ci-helpers and their download site said they haven't changed miniconda installer since April 2019. But something has definitely changed with this tox + virtualenv + conda + CI combo

@adrn adrn mentioned this pull request Oct 15, 2020
Closed
6 tasks
@adrn
Copy link
Owner

adrn commented Oct 15, 2020

Aha! See issue here: ContinuumIO/anaconda-issues#12094

@pllim pllim mentioned this pull request Oct 15, 2020
Merged
@adrn adrn merged commit 9c0c98a into adrn:main Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfm @adrn