-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add published_at
/announced_at
columns to Talk
and use date
for talk date
#616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
published_at
column to Talk
model and use date
for the actual talk date
adrienpoly
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, this will be much more precise than just the current date attribute
not really sure why some test are failing probably something with the fixtures???
Yeah, it was mostly because of the new validation that requires a date to be present for a talk. |
published_at
column to Talk
model and use date
for the actual talk datepublished_at
/announced_at
columns to Talk
and use date
for talk date
published_at
/announced_at
columns to Talk
and use date
for talk datepublished_at
/announced_at
columns to Talk
and use date
for talk date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
published_at
andannounced_at
columns to theTalk
model so we can use thedate
column for the actual Talk date.This pull request also updates all the YAML files to reorganize the two date fields and adds the missing date respectively.
I'm hoping that we can backfill the remaining missing
published_at
dates from YouTube via the API.Resolves #134
Resolves #470