Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add published_at/announced_at columns to Talk and use date for talk date #616

Merged
merged 28 commits into from
Jan 31, 2025

Conversation

marcoroth
Copy link
Collaborator

@marcoroth marcoroth commented Jan 30, 2025

This pull request adds a published_at and announced_at columns to the Talk model so we can use the date column for the actual Talk date.

This pull request also updates all the YAML files to reorganize the two date fields and adds the missing date respectively.

I'm hoping that we can backfill the remaining missing published_at dates from YouTube via the API.

Resolves #134
Resolves #470

@marcoroth marcoroth changed the title Published at column Add published_at column to Talk model and use date for the actual talk date Jan 30, 2025
Copy link
Owner

@adrienpoly adrienpoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, this will be much more precise than just the current date attribute

not really sure why some test are failing probably something with the fixtures???

@marcoroth
Copy link
Collaborator Author

Yeah, it was mostly because of the new validation that requires a date to be present for a talk.

@marcoroth marcoroth changed the title Add published_at column to Talk model and use date for the actual talk date Add published_at/announced_at columns to Talk and use date for talk date Jan 31, 2025
@marcoroth marcoroth changed the title Add published_at/announced_at columns to Talk and use date for talk date Add published_at/announced_at columns to Talk and use date for talk date Jan 31, 2025
@marcoroth marcoroth merged commit d585358 into adrienpoly:main Jan 31, 2025
4 checks passed
@marcoroth marcoroth deleted the published-at-column branch January 31, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Talk model: date and published_at dates Rename Talk published_at to date or similar
2 participants