fix: make plugin usable on Windows #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriencaccia
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
Great work @coyoteecd 🚀
We can ship this, just need to be conflict free on main.
You can rebase your branch 😉
- replace usage of mkdir CLI with equivalent Node API - replace usage of unzip CLI with node-stream-zip lib - use os.tempdir() for getting a cross-platform temp directory - replace path concatenation with join/normalize otherwise fileName.includes(handlerPath) never succeeds because of path separator mismatch Closes #7
|
@adriencaccia rebased |
|
Thanks for the PR 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
never succeeds because of path separator mismatch
Closes #7