fix: get artefact and metafile paths from Serverless API #2
Conversation
| .find(fullFunctionName => fullFunctionName.endsWith(functionName)); | ||
|
|
||
| if (functionZipName === undefined) { | ||
| const fullZipPath = slsFunction.package?.artifact; |
There was a problem hiding this comment.
something like /home/me/projects/foo/.serverless/myfunction.zip
| @@ -57,6 +56,7 @@ async function bundleVisualizer(this: ServerlessAnalyzeBundlePlugin): Promise<vo | |||
|
|
|||
| return; | |||
| } | |||
| const functionZipName = parse(fullZipPath).base; | |||
There was a problem hiding this comment.
just the file and ext, e.g. myfunction.zip
plugin/bundleVisualizer.ts
Outdated
| )[0]; | ||
| const allFiles = getAllFiles(`${TEMP_DIR_LOCATION}`); | ||
| const metafileName = allFiles.filter(fileName => { | ||
| const handlerPath = (slsFunction as FunctionDefinitionHandler).handler.split('.')[0]; |
There was a problem hiding this comment.
will return the value configured in serverless.yml for the function handler, e.g. src/handlers/foo.main. We use split to get just up to the . as the part that follows is the exported function name
| if (!metafileName) { | ||
| this.serverless.cli.log( | ||
| `🤯 Analyze failed: function ${functionName} metadata was not found`, | ||
| 'ServerlessAnalyzeBundlePlugin', | ||
| { color: 'red' }, | ||
| ); | ||
|
|
||
| return; | ||
| } |
There was a problem hiding this comment.
Add explicit error handler here, since I was getting uncaught errors prior to fixing this.
smbkr
changed the title
smbkr
changed the title
Gets the paths to the metadata file and the zipped artifact from the FunctionDefinitionHandler object exposed by the Serverless API. This makes the plugin work correctly when e.g. the handler path is something like `src/myFunctionHandler.main`. Previously this was failing for me where e.g. the function name in Serverless was 'myFunction' but the file path was `myFunctionHandler.ts`.
There was a problem hiding this comment.
Hey @smbkr !
Thanks for the issue, the explanation and the fix in this PR 🥳
I am both amazed and grateful by the quality of your contribution !
I tested your fix with both serverless-esbuild@1.17.1 and serverless-esbuild@1.24.1, it works for both.
I will release your fix in a 1.0.6 version.
Gets the paths to the metadata file and the zipped artifact from the FunctionDefinitionHandler object exposed by the Serverless API.
The current release fails for me where e.g. the function name in Serverless is 'myFunction' but the file path is
myFunctionHandler.ts, as the current implementation assumes the filename and function name are the same which may not be the case. ESBuild outputs the metafile as${sourceFileName}-meta.json.The current implementation also assumes the full function name (
stack-stage-function) is the same as the output zip file, however in my case the output file is just the function name sans stage and stack. This PR fixes this by getting the path from the Serverless API.Fixes #1