Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voyager hilt support broken with Dagger 2.51 #346

Closed
Tolriq opened this issue Mar 1, 2024 · 1 comment · Fixed by #388
Closed

Voyager hilt support broken with Dagger 2.51 #346

Tolriq opened this issue Mar 1, 2024 · 1 comment · Fixed by #388

Comments

@Tolriq
Copy link

Tolriq commented Mar 1, 2024

Dagger 2.51 (https://github.com/google/dagger/releases/tag/dagger-2.51) have breaking change impacting Voyager.

This is probably caused by google/dagger@408431a and the constructor of InternalViewModelFactory being internal.
nvkleban added a commit to nvkleban/voyager that referenced this issue Apr 7, 2024
@nvkleban
Fix: adrielcafe#346 Voyager hilt support broken with Dagger 2.51
6feddbb
@nvkleban nvkleban mentioned this issue Apr 7, 2024
Merged
@nvkleban
Copy link
Contributor

nvkleban commented Apr 7, 2024

I made a small PR with fix, waiting for approval.

DevSrSouza pushed a commit that referenced this issue Apr 7, 2024
@nvkleban
Fix: #346 Voyager hilt support broken with Dagger 2.51 (#388)
0188e00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: #346 Voyager hilt support broken with Dagger 2.51 nvkleban/voyager
2 participants
@Tolriq @nvkleban